Makes port optional in the URL for serverless compute #2
Merged
zhouzypaul merged 3 commits intozhouzypaul:no-portfrom Apr 22, 2025
Merged
Makes port optional in the URL for serverless compute #2zhouzypaul merged 3 commits intozhouzypaul:no-portfrom
zhouzypaul merged 3 commits intozhouzypaul:no-portfrom
Conversation
Owner
|
Thanks for the PR! We would also need to modify this API endpoint here to support testing the connecting without having a port: Line 259 in 89d9aba |
Contributor
Author
|
@zhouzypaul made a helper function and updated the downstream messages! |
Owner
|
Thanks! Will merge in a branch for testing! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the implementation for hosting server-side models relies on binding to a "port" number such as 8000. However, if we want to use cloud-based compute orchestration platforms like Modal, there's no persistent port as the provider handles all the networking. We want to make the port number optional for the URL.
In auto_eval Job SQLModel,
policy_server_portis cast as an integer type. In order to prevent database migration, we use-1as a sentinel value to avoid adding the port to the URL.See similar PR in
mse-checkrepo: zhouzypaul/mse-check#1